Enable unsafe PR checkout in ASIM workflow - #14787
Open
v-sabiraj wants to merge 1 commit into
Open
Conversation
Adds `allow-unsafe-pr-checkout: true` to all PR checkout steps in `runAsimSchemaAndDataTesters.yaml`. This ensures each job can reliably checkout the pull request head SHA in the current repository configuration.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Enables the workflow to check out the PR head SHA by adding allow-unsafe-pr-checkout: true to PR checkout steps in the ASIM schema/data tester workflow.
Changes:
- Adds
allow-unsafe-pr-checkout: trueto multiple checkout steps inrunAsimSchemaAndDataTesters.yaml.
Comment on lines
357
to
362
| with: | ||
| ref: ${{github.event.pull_request.head.sha}} | ||
| repository: ${{ github.repository }} | ||
| allow-unsafe-pr-checkout: true | ||
| persist-credentials: false # otherwise, the token used is the GITHUB_TOKEN, instead of your personal access token. | ||
| fetch-depth: 0 # otherwise, there would be errors pushing refs to the destination repository. |
Comment on lines
412
to
417
| with: | ||
| ref: ${{github.event.pull_request.head.sha}} | ||
| repository: ${{ github.repository }} | ||
| allow-unsafe-pr-checkout: true | ||
| persist-credentials: false # otherwise, the token used is the GITHUB_TOKEN, instead of your personal access token. | ||
| fetch-depth: 0 # otherwise, there would be errors pushing refs to the destination repository. |
| with: | ||
| ref: ${{ github.event.pull_request.head.sha }} | ||
| repository: ${{ github.repository }} | ||
| allow-unsafe-pr-checkout: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
allow-unsafe-pr-checkout: trueto all PR checkout steps inrunAsimSchemaAndDataTesters.yaml. This ensures each job can reliably checkout the pull request head SHA in the current repository configuration.Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present:
Guidance <- remove section before submitting
Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.
Change(s):
Reason for Change(s):
Version updated:
Testing Completed:
Note: If updating a detection, you must update the version field.
Checked that the validations are passing and have addressed any issues that are present:
Note: Let us know if you have tried fixing the validation error and need help.